#1
Ahoy!

I’ve been working on a completely overhauled version of the framework’s validation module - rebuilt from the ground up and handled in a very different way. Even though the internals have changed there should be no breaking changes whatsoever.

I’m genuinely excited about this, and I’m planning a live launch on Thursday night.

That said, there’s quite a lot going on under the hood, so I’d really value a second pair of eyes (or several). If you’re willing to help test it, I’ll get the code over to you and put together a short private video walking you through how everything works.

From there, it’s simply a matter of putting it through its paces and letting me know your thoughts.

I appreciate this is short notice, but it’s important to get this right - and if that means delaying the launch, so be it.

If you’re up for helping test this, please leave a comment below.

*** I would consider it a huge personal favour if you could help me with this! ***

Cheers!

DC
#2
Hi DC,

I'd be happy to help test the new validation module. Send over whatever you have ready, and I'll aim to get feedback to you by Thursday.

Cheers,
#3
DC

You can send it to me and i'll check it out.

Dan
#4
I'd love to help out with this, Dave. Count me in for testing the new validation module!
#5
Bit late to the party, but send via What's app DC if you need more testers
#6
Thanks folks. You'll all be getting it first. I'm just finishing this thing off and, soon, I'll come back with a link that'll give you everything you need.

I may not have this ready in time for tomorrow's launch - but that's okay.

Let's take our time with this and get it right. Even if I have to delay the YouTube video and/or let people know that I'm awaiting feedback from you then that will be cool.

Nothing is carved in stone and it's open source. So, I'll be welcoming any feedback and contributions when the time comes.

Thanks again. I'll be right back!
#7
Okay folks, here is your highly top secret video and a link to the GitHub repo is in the description:

https://www.youtube.com/watch?v=SoRR9cQ6Pak


Thank you so much for all of your help with this!

DC
#8
Great work, DC!

A ton has changed, there's only so much that can be tested before today's livestream.

Manually, I tested some obviously fake images (a text file with the extension changed to .jpg and .gif, with and without PHP tags in the text), and also toggled the languages; the correct message is displayed for the cases I tried (allowed image types, is image, threat detected), and the appropriate message displayed in English, French, Spanish.

Comparing the validacious repo against the latest version of the framework from two weeks ago in Git, the one obvious out-of-place line I caught was in modules/welcome/views/default_homepage.php

I asked GitHub Copilot to flag breaking changes. It recommended: Any existing code using custom validation callbacks (callback_* rules) will need to be tested to ensure the automatic caller injection works correctly in the new architecture.
#9
Thank you very much. I've removed that.

There is indeed quite a lot that has been done. Getting this right was major surgery. It'll probably take about a week of testing until we can declare it as being ready to rock.

Cheers for that!
#10
Just to say, Sasin left the following post elsewhere but didn't give any context ---

You can use https://www.php.net/manual/en/closure.bindto.php and https://www.php.net/manual/en/function.debug-backtrace.php in Templates.php render to bind $this as to the calling class / module.

This would effectively make the view file extend from the controller :)

--- Let me be honest. I don't entirely understand the comment. The 'validation' module is outrageously complicated. I dare say, the logic for clearing of validation errors is beyond what any AI tool could handle. Trust me, I've spent a solid week on this. I had four different AI tools looking at this and they couldn't solve it.

So, I have no shame whatsoever in telling you all that this is complicated.

That said, short, cryptic comments that link to documentation and have an obligatory smug smilie face are somewhat disappointing.

In any event, I wonder if his comment is worth looking into. It probably is.