Hello DC,

If you explain what you need to accomplish, changing the form open or whatever, I would be glad to try and get that accomplished. You can send me the info to my email or post here.

Dan

Hello Dave,

I agree, it's definitely safer to handle this manually than to risk further complications with an AI fix.
I've put my work gloves on and have reverted all of the function headers (manually, one-by-one) so that they match the originals.

The pull request has been sent.

Wow! That is mind blowing and incredible. I can't believe what I'm seeing.

Thank you!

I think I saw Simon mention the docs. So, just to let you know... I think the docs for this are about 90% complete but there may be some bits and pieces that need sorted - particularly for the Reference Guide. I'll be happy to do that. However, if it's of use then I'll be glad to upload all of the docs (to GitHub) too. Just to be clear, we currently have the old v1 docs on GitHub but the new docs for v2 are currently not on GitHub. So, I'm just saying, if you think it would be useful to have those v2 docs on GitHub so that people can contribute then do let me know.

That being said, the Ninja has really helped us out here. How he did it, I do not know. I'm calling it a miracle.

So, I'm not going to push my luck by asking for more help. However, since the docs were mentioned (over on GitHub), I'm just saying that I'll be glad to upload all the docs if you want. The docs are all written in plain HTML.

ONE QUESTION: I have accepted the pull request and I could see a whole bunch of positive test results. Do you think this thing is ready to add to the main Trongate framework, or do you think we should take more time for testing/whatever?

Many thanks again. This is great!

Hey DC,

I’ve submitted another PR following on from Balazs’ work. This one resolves the five undefined variables and tightens up some type issues in "form_helper.php". I’ve also included helper tests to cover each case and a general purpose helper tester module.

That said, I think we still need broader testing before we can confidently move toward merging this into Trongate.

Cheers,
Si

Thanks Simon. I had a look there and that was a really important pull request. Nice job spotting that.

Let me apologise in advance if I'm not entirely with it for the next couple of weeks. I've had a situation here that demands my attention and it's serious enough to divert my attention from Trongate. Everybody is healthy but there's something I really have to deal with. A sort of emergency.

I'll tell you about it when the dust settles. In the meantime, I trust you guys and I will - of course - take your advice on what to do as far as pull requests etc goes.

Cheers!

Thank you, DC. No magic involved there, just a lot of hard manual labor! 🙂 I'd love to see the v2 docs made available on GitHub. I'd be more than happy to contribute to the documentation as well.

Simon, you did a brilliant job fixing those undefined variables. You rock, as always, and I'm so glad you helped us out with your expertise!

I also wholeheartedly agree with Simon that the Service Routing update isn't quite ready to be merged into the main framework.

During further testing, I noticed the submit buttons lost their styling. I've already sent over a pull request with the fix, but it's a good reminder that we should keep testing to see if anything else surfaces.

Thanks Balazs, I also had the submit button flagged.

Just sent PR to fix the offset in segment() was returning app folder name as segment 1 instead of controller name, now tg-admin works as expected.

Thanks for all the help with this and I can see that we now have three people who have submitted pull requests. That's amazing.

We do, however, seem to have loads of bugs and I'm blaming AI for that.

I'm not sure of the state of the thing so let me ask you a question:

QUESTION: Which of the following options would you support at this juncture?

OPTION 1: Performing a massive "undo" and just doing this entire switch manually? If we do it manually, there's a far smaller chance of there being bugs and even if there are bugs we'll be able to fix them fast.

OPTION 2: Just press forward with what we're doing because, after all, maybe it's not so bad.

DC

I think opt 2 - press on. Come this far, but there are bound to be some edge cases left to iron out.

*equips PM hat* I suggest option 2, I have very rarely participated a big reset that was worth the time.
It may be worth documenting the flaws, shortcomings and sharp edges for retrospective on what can be better next time around.