I need a favour - Trongate v2

5 months ago

#11

Hi DC,
I tested with my account and created a test account HeerwaardenTest.

1. superfast response:)
2. no issues in the workflows
3. one thing to finetune

---

---
With this account it was the first login. Welcome only is enough:).

Great.I love it

Jerry

5 months ago

#12

And just 2 additional thoughts:
1. After clicking [Log Out], one is redirected to the log-in page. That only makes sense if you assume people log out by accident. I mostly log out on purpose, so it would make more sense (to me) to return to the Forum homepage or the site's homepage.
2. My favorite: When logged out and I push [Compose reply] I get the Members Login page (obviously), but after logging in the Members Details page is presented, where I would like to be redirected to the page I came from (like I proposed some time ago for the v1 version)
3. {Bonus}: It would make more sense to me to only have the [Compose Reply] button on the very last page of a thread.
But no biggies. =8-)
Kool Mees

Edit:
I tried to send a message via the contactus page, but the Submit gives a 500. =8-(
So I will add my message below:

Hello DC,
You can delete the test-account I created (NotJustKoolmees). I want to keep my account 'Koolmees', just 'Koolmees' and not NotJustKoolmees.

O, and something is really, really off in the leaderboard function. There is no way I got to #2, just between you and Dafa (so the ordering is neither by intelligence - I would not be on that list - nor stupidity - I would be 1st). And with some minor remarks on a test-account I have surpassed codemonkey? That cannot be true!
On a personal note:
Some years ago I was looking for guidance in using the Slim Framework and found your Tutorials (I really enjoyed). In one of the comments you mentioned Trongate and made me turn my back to Angular 3 (or was it 4, 5, 6, .... don't remember). I rewrote my apps and websites (away from Joomla! 3? 4? was it 5?) and all run smoothly ever since. Your work has had a huge impact and I am very grateful for what you created.
Thank you!
Have a nice day!

5 months ago

#13

Thank you everybody. I'm very happy with how this is going and I'm super grateful for all you've done.

I'll post updates when the various suggestions have been done and dusted. That new account that was mentioned and any others will be deleted. So, you're very welcome to create test accounts safe in the knowledge that they'll be deleted and now is a good time to do so.

Rest assured, I'm on the case.

Thank you!

5 months ago

#14

Hi guys,

Looks like it's a wrap, and everything is working as expected.

I've created a pull request to the members_app to fix the missing columns in the `members` table and added the missing tables to get the join and reset password working

5 months ago

#15

Thanks. That's now merged.

5 months ago

#16

I'm about to get cracking with the next few tweaks.

NotJustKoolmees - You submitted a variety of suggestions that are all cool but they're probably not going to happen. At least, not now.

When people log out, I like to redirect them to the log-in page. Usually, the log-in page(s) contain code that guarantees that the person is logged out. So, if I'm looking at a "log-in" page then I"m confident that I've logged out. I don't get the same feeling, if I log out (or if I'm accidentally logged out) and I'm looking at a home page. This is, of course, just a personal preference of mine. I don't have a monopoly on the truth and I'm open to having my mind changed. However, time is luxury that I don't have and I really need to move on. There are boat loads of other things that urgently need attention. I'm sure you understand.

Same goes for your other two suggestions. They're both reasonable - particularly your idea about the user being taken back to their original page after being logged in. There's no question, this is a cool feature to have. I want it. The trouble is, we're coming back from a lot of bugs. Right now, and I don't want to add any fanciness whatsoever.

Right now, I'm only interested in making the thing WORK.

In time, once the dust has settled and we're all confident that this thing is working then I'll certainly be glad to go through all of your suggestions.

Regarding the leaderboard: I think the scoring works. I'm going to publish how points get calculated for the leaderboard. You'll see that soon and once that goes up, you'll be able to double check and confirm that the points are being calculated correctly.

Rest assured, test accounts will be getting deleted and thanks for creating them.

I'm super grateful for all your help with this.

I'd be grateful if we could shift gears a little and if you could focus on telling me about faults. I want to put a video out next week, telling people that the forum is fixed.

You've all been great. Thank you!

DC

5 months ago

#17

I tend to agree that when a user logs out they are directed to the login page. Because that is like a message that you did log out. Extra click to get to the home page, true but worth it to let the user know they logged out.
Just my 2 cents worth,
Dan

5 months ago

#18

★ Winning Post! ★

The thread creator has indicated that this post solved the problem or provided the best insight.

Members who post winning responses earn points for our leaderboard.

Points mean prizes!

Fair enough David. No nuances for now.

Well, I've gone through and tested all the main features:

✅ Sign up form
✅ Activation email (arrived, no spam)
✅ User activation link
✅ User activation button
✅ Update password
✅ Activation link expiry (cannot be re-used)
✅ Update account details
✅ Change password
✅ Login/Logout
✅ Compose/Submit reply

Overall, it's a 10 out of 10. 👍🏻

5 months ago

#19

That's amazing, thank you.

I've done a lot of work this weekend, fixing and tweaking things. Even one or two framework tweaks (no breaking changes). So, I'm looking forward to uploading.

Many thanks indeed,

DC

5 months ago

#20

Okay, I've now gone through all of the various tweaks and suggestions that were offered (with the few exceptions I mentioned yesterday). Hopefully that's us good, for now. However, if there's anything that's not right - let me know and I'll get on the case for you.

I've also added a search engine to the docs and carried out a few other tweaks. There was also some framework updates this morning (non-breaking).

There's still a lot to be built for this eco-system. We're just getting warmed up.

DC